Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored the use of ClaimLite and ClaimsRecord into a single type. #1756

Merged

Conversation

Erwinvandervalk
Copy link
Contributor

@Erwinvandervalk Erwinvandervalk commented Feb 4, 2025

What issue does this PR address?
Refactor The use of ClaimLite and ClaimsRecord into a single type. I decided to use the name 'ClaimsRecord' because it was already part of the public contract (it's protected but still it's part of the signature of the DefaultUserService)

TargetFrameworks vs TargetFramework

There also turned out to be some compile issues. Hence, this PR also adds the
net9.0 to the samples folder. (note ONLY to the samples folder).

The reasoning for this is:
Aspire needs a single target framework
(until this is resolved: dotnet/aspire#2962)

When you add <TargetFrameworks>net9.0</TargetFrameworks> then aspire thinks there are more than
one framework. But this causes a problem for the Directory.Packages.props file.

In the Directory.Packages.props where we check for $(TargetFramework) == 'net9.0',
which is ONLY set if you use <TargetFrameworks>net9.0</TargetFrameworks> in the csproj file, not
if you set <TargetFramework>. 

Now normally it's not recommended to set both, however, since this is only for samples, AND
we do need this check, we're setting it here as well. 

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

@Erwinvandervalk Erwinvandervalk added impact/breaking The fix or change will be a breaking one area/bff Related to all BFF labels Feb 4, 2025
@Erwinvandervalk Erwinvandervalk self-assigned this Feb 4, 2025
@Erwinvandervalk Erwinvandervalk removed the impact/breaking The fix or change will be a breaking one label Feb 4, 2025
@Erwinvandervalk Erwinvandervalk force-pushed the bff-claims-lite branch 2 times, most recently from 5c2e03b to b2c122b Compare February 4, 2025 15:46
@Erwinvandervalk Erwinvandervalk merged commit 0fe5539 into DuendeSoftware:main Feb 4, 2025
9 of 11 checks passed
@Erwinvandervalk Erwinvandervalk deleted the bff-claims-lite branch February 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bff Related to all BFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for multiple TFMs <TargetFrameworks>
2 participants